update:修改上架时间的判断

application/exception/custom/GoodsException.php

@@ -65,5 +65,6 @@ class GoodsException extends BaseException
         46 => '已经执行过cancel',
         47 => 'sku rollback error',
         48 => '请满足以下条件后提交，售价-分销总金额-手续费>=结算价',
+        49 => '商品过期时间小于等于，上架时间',
     ];
 }
\ No newline at end of file

application/services/goods/GoodsService.php

@@ -278,6 +278,15 @@ class GoodsService
                 break;
         }
 
+        if (!empty($skuData["online_type"])) {
+            //立即上架和定时上架
+            if (in_array($skuData["online_type"], [1,2])) {
+                if ($skuData["expiration_time"] <= $skuData['online_start_time']) {
+                    throw new GoodsException(["cus" => 49]);
+                }
+            }
+        }
+
         GoodsSku::save($skuParams);
         self::addGoodsSkuPicRecord($skuId, $skuData);
         return $skuId;
@@ -425,27 +434,26 @@ class GoodsService
                         "rejected_reason" => $rejectedReason
                     ];
                 }
-
-                $online_type = empty($sku["online_type"]) ? 0 : $sku["online_type"];
-
-                if ($online_type == 1) {
-                    if ($status == GoodsSku::STATUS_PASS) {
+                
+                if ($status == GoodsSku::STATUS_PASS) {
+                    $online_type = empty($sku["online_type"]) ? 0 : $sku["online_type"];
+                    if ($online_type == 1) {
                         $statusData['online_status'] = GoodsSku::ONLINE_STATUS_ONLINE;
                         $statusData['online_start_time'] = date("Y-m-d H:i:s");
                     }
-                }
-                
-                //定点上架
-                if ($online_type == 2) {
-                    $onlineStartTime = empty($sku["online_start_time"]) ? 0 : strtotime($sku["online_start_time"]);
-                    if ($onlineStartTime > time()) {
-                        $statusData['online_status'] = GoodsSku::ONLINE_STATUS_NO_ONLINE;
+                    
+                    //定点上架
+                    if ($online_type == 2) {
+                        $onlineStartTime = empty($sku["online_start_time"]) ? 0 : strtotime($sku["online_start_time"]);
+                        if ($onlineStartTime > time()) {
+                            $statusData['online_status'] = GoodsSku::ONLINE_STATUS_NO_ONLINE;
+                        }
                     }
-                }
 
-                //暂不上架
-                if ($online_type == 3) {
-                    $statusData['online_status'] = GoodsSku::ONLINE_STATUS_NO_ONLINE;
+                    //暂不上架
+                    if ($online_type == 3) {
+                        $statusData['online_status'] = GoodsSku::ONLINE_STATUS_OFFLINE;
+                    }
                 }
 
                 GoodsSku::save($statusData, ["goods_sku_id" => $sku["goods_sku_id"]]);
@@ -571,6 +579,7 @@ class GoodsService
         $goodsSkuList = GoodsSku::select("*", ["goods_spu_id" => $goodsSpuId]);
         if (!empty($goodsSkuList)) {
             foreach ($goodsSkuList as $sku) {
+
                 $goodsSkuId = $sku["goods_sku_id"];
                 $goodsSkuData = [
                     "online_type" => $onlineType,
@@ -596,7 +605,14 @@ class GoodsService
                         $goodsSkuData['online_status'] = 0;
                     }
                 }
-                
+
+                //立即上架和定时上架
+                if (in_array($onlineType, [1,2])) {
+                    if ($sku["expiration_time"] <= $goodsSkuData['online_start_time']) {
+                        throw new GoodsException(["cus" => 49]);
+                    }
+                }
+
                 GoodsSku::save($goodsSkuData, ["goods_sku_id" => $goodsSkuId]);
                 //上架的话，生成快照
                 self::addGoodsSnapshot($sku);
@@ -828,6 +844,16 @@ class GoodsService
             $skuParams['online_type'] = empty($params["online_type"]) ? 0 : $params["online_type"];
         }
 
+
+        if (!empty($params["online_type"])) {
+            //立即上架和定时上架
+            if (in_array($params["online_type"], [1,2])) {
+                if ($skuData["expiration_time"] <= $skuParams['online_start_time']) {
+                    throw new GoodsException(["cus" => 49]);
+                }
+            }
+        }
+
         //商品操作记录
         $record = [
             "goods_spu_id" => $skuData["goods_spu_id"],